dajac commented on code in PR #16859:
URL: https://github.com/apache/kafka/pull/16859#discussion_r1715177351
##########
core/src/main/scala/kafka/server/ConfigHelper.scala:
##########
@@ -149,6 +153,19 @@ class ConfigHelper(metadataCache: MetadataCache, config:
KafkaConfig, configRepo
.setConfigs(configEntries.asJava)
}
+ case ConfigResource.Type.GROUP =>
+ val group = resource.resourceName
+ if (group == null || group.isEmpty) {
+ throw new InvalidRequestException("Group name must not be empty")
+ } else {
+ val groupProps = configRepository.groupConfig(group)
+ val groupConfig =
GroupConfig.fromProps(config.groupCoordinatorConfig.extractGroupConfigMap,
groupProps)
Review Comment:
Thanks. So we always return all the configs when describing. However, we
distinguish between default and dynamic entries in the response. How do we
differentiate between using DEFAULT_CONFIG or GROUP_CONFIG in our case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
