DL1231 commented on code in PR #16859:
URL: https://github.com/apache/kafka/pull/16859#discussion_r1715135553
##########
core/src/main/scala/kafka/server/ConfigHelper.scala:
##########
@@ -149,6 +153,19 @@ class ConfigHelper(metadataCache: MetadataCache, config:
KafkaConfig, configRepo
.setConfigs(configEntries.asJava)
}
+ case ConfigResource.Type.GROUP =>
+ val group = resource.resourceName
+ if (group == null || group.isEmpty) {
+ throw new InvalidRequestException("Group name must not be empty")
+ } else {
+ val groupProps = configRepository.groupConfig(group)
+ val groupConfig =
GroupConfig.fromProps(config.groupCoordinatorConfig.extractGroupConfigMap,
groupProps)
Review Comment:
If dynamic configuration is not set, the source of config is
`DEFAULT_CONFIG,` and only the configuration with source `DYNAMIC_TOPIC_CONFIG
` will be filtered out in `ConfigCommand`.
https://github.com/apache/kafka/blob/25b955ddf2253ce76354eee8705155e96ee003fa/core/src/main/scala/kafka/admin/ConfigCommand.scala#L593
https://github.com/apache/kafka/blob/25b955ddf2253ce76354eee8705155e96ee003fa/core/src/main/scala/kafka/admin/ConfigCommand.scala#L620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
