dajac commented on PR #16859: URL: https://github.com/apache/kafka/pull/16859#issuecomment-2284503793
@DL1231 Thanks for the patch. I did not fully review it yet but I already have a few high level points: * Should we add some integration tests (e.g. in PlaintextAdminIntegrationTest)? * It would be great if we could extend AuthorizerIntegrationTest to cover the new group config type with the associated ACLs. This is something that we can do in a separate PR though. * The build failed. Could you please check whether it is related to your changes? I triggered a new build too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
