lianetm commented on code in PR #16200:
URL: https://github.com/apache/kafka/pull/16200#discussion_r1668835568
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##########
@@ -277,12 +332,12 @@ public void testHeartbeatNotSentIfAnotherOneInFlight() {
result = heartbeatRequestManager.poll(time.milliseconds());
Review Comment:
I see down below (ln 337-340) the sequence to validate that the interval
expired and no HB is generated because of the inflight. I truly don't see the
value in keeping this one then (ln 333-335), which is not related to in-flight
at all (HB interval is tested in other funcs). Makes sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
