philipnee commented on code in PR #16200:
URL: https://github.com/apache/kafka/pull/16200#discussion_r1668899064
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##########
@@ -251,23 +304,25 @@ public void testSkippingHeartbeat(final boolean
shouldSkipHeartbeat) {
@Test
public void testTimerNotDue() {
- mockStableMember();
time.sleep(100); // time elapsed < heartbeatInterval, no heartbeat
should be sent
NetworkClientDelegate.PollResult result =
heartbeatRequestManager.poll(time.milliseconds());
+
assertEquals(0, result.unsentRequests.size());
assertEquals(DEFAULT_HEARTBEAT_INTERVAL_MS - 100,
result.timeUntilNextPollMs);
+
+ when(pollTimer.remainingMs()).thenReturn(1800L);
Review Comment:
`1800L` isn't entirely clear to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
