showuon commented on code in PR #16491: URL: https://github.com/apache/kafka/pull/16491#discussion_r1665094501
########## docs/ops.html: ########## @@ -3946,6 +3946,7 @@ <h3>Enter Migration Mode on the Brokers</h3> </p> <ul> + <li><a href="#brokerconfigs_broker.id">broker.id</a>: If <code>broker.id.generation.enable</code> is enabled (default is enabled) and <code>broker.id</code> is not set during migration, it will fail. Ensure <code>broker.id</code> is set to a non-negative integer.</li> Review Comment: Looks better! Maybe we can just say: `Ensure <code>broker.id</code> is set to a non-negative integer even if <code>broker.id.generation.enable</code> is enabled (default is enabled). ` because: 1. we don't need to mention `during migration` since this is a migration section 2. We can combine these 2 sentences. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
