chia7712 commented on PR #16491: URL: https://github.com/apache/kafka/pull/16491#issuecomment-2205570571
> But it fails on the default node.id" <-- what does it mean? > If the ID is successfully generated, it should already be within the reserved range, why do we need another check? The story starts with a zk broker having a generated broker id. Normally, it does not need to define the broker id in the config file. However, that can't work in migration aince Kraft class needs node id and node id is not initialized with (generated) broker id. If we add the (generated) broker id to config file to initialize both ids, it can't pass the check due to reservation rules. > the root cause of the issue is the generated ID doesn't pass to node.id, which causes this error when startup, is that correct? You are right and that is the root cause. > ? If so, why cannot we fix the issue by setting node.id = generated ID, if not set? That can fix the issue. The concern is that the node.id will be a mutable variable rather than a value from configs. That opens a dangerous door that enable everyone to change it in everywhere. Maybe another solution is we can skip the id value check if it is in zk migration. The side effect is that zk broker needs to define broker id in config file for migration even though generated id is enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
