rreddy-22 commented on code in PR #16068:
URL: https://github.com/apache/kafka/pull/16068#discussion_r1624850259
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilderTest.java:
##########
@@ -271,45 +268,37 @@ public void
testReassignmentForTwoMembersThreeTopicsGivenUnbalancedPrevAssignmen
mkMapOfPartitionRacks(4)
));
- Map<String, AssignmentMemberSpec> members = new TreeMap<>();
+ Map<String, MemberSubscriptionSpecImpl> members = new TreeMap<>();
+ Map<Uuid, Set<Integer>> targetAssignment;
- Map<Uuid, Set<Integer>> currentAssignmentForA = new TreeMap<>(
- mkAssignment(
- mkTopicAssignment(topic1Uuid, 0, 1, 2)
- )
+ targetAssignment = mkAssignment(
+ mkTopicAssignment(topic1Uuid, 0, 1, 2)
);
Review Comment:
It's okay I'll inline it if you feel like it's fine. I thought you would
want it to be more concise lol
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilderTest.java:
##########
@@ -271,45 +268,37 @@ public void
testReassignmentForTwoMembersThreeTopicsGivenUnbalancedPrevAssignmen
mkMapOfPartitionRacks(4)
));
- Map<String, AssignmentMemberSpec> members = new TreeMap<>();
+ Map<String, MemberSubscriptionSpecImpl> members = new TreeMap<>();
+ Map<Uuid, Set<Integer>> targetAssignment;
- Map<Uuid, Set<Integer>> currentAssignmentForA = new TreeMap<>(
- mkAssignment(
- mkTopicAssignment(topic1Uuid, 0, 1, 2)
- )
+ targetAssignment = mkAssignment(
+ mkTopicAssignment(topic1Uuid, 0, 1, 2)
);
Review Comment:
It's okay I'll inline it if you feel like it's fine. I thought you would
want it to be more concise lol, it's a reverse uno
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
