rreddy-22 commented on code in PR #16068:
URL: https://github.com/apache/kafka/pull/16068#discussion_r1624804356
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilderTest.java:
##########
@@ -294,26 +295,27 @@ public void
testReassignmentForTwoMembersTwoTopicsGivenUnbalancedPrevAssignment(
mkMapOfPartitionRacks(3)
));
- Map<String, AssignmentMemberSpec> members = new TreeMap<>();
+ Map<String, MemberSubscriptionSpecImpl> members = new TreeMap<>();
+ Map<Uuid, Set<Integer>> targetAssignment;
- members.put(memberA, new AssignmentMemberSpec(
- Optional.empty(),
+ targetAssignment = mkOrderedAssignment(
+ mkTopicAssignment(topic1Uuid, 0, 1),
+ mkTopicAssignment(topic2Uuid, 0, 1)
+ );
+ members.put(memberA, new MemberSubscriptionSpecImpl(
Optional.empty(),
mkSet(topic1Uuid, topic2Uuid),
- mkOrderedAssignment(
- mkTopicAssignment(topic1Uuid, 0, 1),
- mkTopicAssignment(topic2Uuid, 0, 1)
- )
+ new Assignment(targetAssignment)
Review Comment:
It's not very readable to me that way, but maybe we shouldn't use the same
variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
