dajac commented on code in PR #16068:
URL: https://github.com/apache/kafka/pull/16068#discussion_r1625434453
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilderTest.java:
##########
@@ -271,18 +277,17 @@ public void testCreateAssignmentMemberSpec() {
mkTopicAssignment(barTopicId, 1, 2, 3)
));
- AssignmentMemberSpec assignmentMemberSpec = createAssignmentMemberSpec(
+ MemberSubscriptionSpec subscriptionSpec =
createMemberSubscriptionSpecImpl(
member,
assignment,
topicsImage
);
- assertEquals(new AssignmentMemberSpec(
- Optional.of("instanceId"),
+ assertEquals(new MemberSubscriptionSpecImpl(
Optional.of("rackId"),
new TopicIds(mkSet("bar", "foo", "zar"), topicsImage),
- assignment.partitions()
- ), assignmentMemberSpec);
+ assignment
+ ), subscriptionSpec);
Review Comment:
nit: The indentation seems to be off here. I think that it should be as it
was before.
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilderTest.java:
##########
@@ -253,13 +252,15 @@ public void testValidityAndBalanceForLargeSampleSet() {
));
}
- Map<String, AssignmentMemberSpec> members = new TreeMap<>();
+ List<Uuid> subscribedTopics = new ArrayList<>(topicMetadata.keySet());
Review Comment:
nit: This change does not seem necessary. We start from a Set, convert it to
a List, and finally convert it back to a Set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
