cadonna commented on code in PR #15581:
URL: https://github.com/apache/kafka/pull/15581#discussion_r1537642692
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -298,10 +303,13 @@ private void
autoCommitSyncNowWithRetries(OffsetCommitRequestState requestAttemp
if (error == null) {
result.complete(null);
} else {
- if (error instanceof RetriableException ||
isStaleEpochErrorAndValidEpochAvailable(error)) {
+ if ((error instanceof RetriableException ||
isStaleEpochErrorAndValidEpochAvailable(error))) {
if (error instanceof TimeoutException &&
requestAttempt.isExpired) {
log.debug("Auto-commit sync timed out and won't be
retried anymore");
result.completeExceptionally(error);
+ } else if (error instanceof
UnknownTopicOrPartitionException) {
+ log.debug("Auto-commit sync failed because topic or
partition were deleted");
Review Comment:
I added the `before revocation` to all log messages in this method, since it
actually applies to all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
