lianetm commented on code in PR #15581:
URL: https://github.com/apache/kafka/pull/15581#discussion_r1537618245
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -298,10 +303,13 @@ private void
autoCommitSyncNowWithRetries(OffsetCommitRequestState requestAttemp
if (error == null) {
result.complete(null);
} else {
- if (error instanceof RetriableException ||
isStaleEpochErrorAndValidEpochAvailable(error)) {
+ if ((error instanceof RetriableException ||
isStaleEpochErrorAndValidEpochAvailable(error))) {
if (error instanceof TimeoutException &&
requestAttempt.isExpired) {
log.debug("Auto-commit sync timed out and won't be
retried anymore");
result.completeExceptionally(error);
+ } else if (error instanceof
UnknownTopicOrPartitionException) {
+ log.debug("Auto-commit sync failed because topic or
partition were deleted");
Review Comment:
nit: would probably make the log clearer to all if we add the before
revocation part `Auto-commit sync **before revocation** failed` (just like you
did for the func name, like it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
