AndrewJSchofield commented on code in PR #15581:
URL: https://github.com/apache/kafka/pull/15581#discussion_r1537243649
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -272,14 +273,18 @@ private void maybeResetTimerWithBackoff(final
CompletableFuture<Map<TopicPartiti
* Commit consumed offsets if auto-commit is enabled, regardless of the
auto-commit interval.
* This is used for committing offsets before revoking partitions. This
will retry committing
* the latest offsets until the request succeeds, fails with a fatal
error, or the timeout
- * expires. Note that this considers {@link Errors#STALE_MEMBER_EPOCH} as
a retriable error,
+ * expires. Note that:
+ * - Considers {@link Errors#STALE_MEMBER_EPOCH} as a retriable error,
* and will retry it including the latest member ID and epoch received
from the broker.
+ * - Considers {@link Errors#UNKNOWN_TOPIC_OR_PARTITION} as a fatal error,
and will not retry
+ * it although the error extends RetrieableException. The reason is that
if a topic or partition
Review Comment:
RetriableException :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
