lucasbru commented on code in PR #15000:
URL: https://github.com/apache/kafka/pull/15000#discussion_r1455660640
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##########
@@ -367,6 +372,42 @@ public void testAutocommitEnsureOnlyOneInflightRequest() {
assertPoll(1, commitRequestManger);
}
+ @Test
Review Comment:
Yes, they should. This is tested in the integration test
`PlaintextConsumer.testAutoCommitIntercept` - which works in terms of
interceptors, but I have to keep disabled in this PR because of KAFKA-16155.
This PR does call the interceptors after closing the network thread (I pinged
you about it above). I can add a little unit test to `AsyncKafkaConsumerTest`.
I don't think we can add a unit test for it in `CommitRequestManagerTest`,
because the autocommit on close is triggered from the application thread, so in
this class it does look very much like any normal commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
