philipnee commented on code in PR #15000:
URL: https://github.com/apache/kafka/pull/15000#discussion_r1453870149
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -93,9 +94,11 @@ public CommitRequestManager(
final SubscriptionState subscriptions,
final ConsumerConfig config,
final CoordinatorRequestManager coordinatorRequestManager,
+ final OffsetCommitCallbackInvoker offsetCommitCallbackInvoker,
final String groupId,
final Optional<String> groupInstanceId) {
- this(time, logContext, subscriptions, config,
coordinatorRequestManager, groupId,
+ this(time, logContext, subscriptions, config,
coordinatorRequestManager,
Review Comment:
i wonder if it would be more aesthetic to split each of them into its own
line.... now it is spanning 3 lines with different widths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
