lucasbru commented on code in PR #15000:
URL: https://github.com/apache/kafka/pull/15000#discussion_r1459285186
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -271,6 +283,7 @@ public CompletableFuture<Void>
maybeAutoCommitAllConsumedNow(
return (response, throwable) -> {
autoCommitState.ifPresent(autoCommitState ->
autoCommitState.setInflightCommitStatus(false));
if (throwable == null) {
+
offsetCommitCallbackInvoker.submitCommitInterceptors(allConsumedOffsets);
Review Comment:
You asked why is "this" only called in the case of the auto commit. I think
you were referring to submitCommitInterceptors. It is not only called in the
case of auto-commit, but also in commitAsync.
Then you mentioned that the name of "this method" is misleading. I think you
are referring to maybeAutocommitAllConsumedNow. I don't think it is, because it
is only called in an auto-commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
