piyushka-ally commented on code in PR #2784:
URL: https://github.com/apache/sedona/pull/2784#discussion_r3028570345
##########
python/tests/geopandas/test_match_geopandas_series.py:
##########
@@ -495,6 +495,27 @@ def test_to_arrow(self):
def test_clip(self):
pass
+ def test_clip_by_rect(self):
+ # Use rect (0.3, 0.3, 1.7, 1.7) so no test-geometry vertex or hole
+ # coordinate (0, 0.1, 0.2, 1, 2, …) lands on a rectangle boundary.
+ # This avoids boundary-handling differences between JTS and GEOS.
+ for geom in self.geoms:
+ # Sedona converts LinearRing to LineString, so geometry types
+ # will differ from geopandas results.
+ if isinstance(geom[0], LinearRing):
+ continue
+ # ST_Intersection returns different results for
+ # GeometryCollection inputs compared to GEOS clip_by_rect.
+ if isinstance(geom[0], GeometryCollection):
+ continue
Review Comment:
You're right, the LinearRing skip isn't needed here either. Removed it in
b23b9a64. The only remaining guard is the is_valid check, which is needed
because JTS throws TopologyException on self-intersecting polygons during
ST_Intersection, while GEOS handles them gracefully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
