piyushka-ally commented on code in PR #2784:
URL: https://github.com/apache/sedona/pull/2784#discussion_r3019781590
##########
python/tests/geopandas/test_match_geopandas_series.py:
##########
@@ -495,6 +495,27 @@ def test_to_arrow(self):
def test_clip(self):
pass
+ def test_clip_by_rect(self):
+ # Use rect (0.3, 0.3, 1.7, 1.7) so no test-geometry vertex or hole
+ # coordinate (0, 0.1, 0.2, 1, 2, …) lands on a rectangle boundary.
+ # This avoids boundary-handling differences between JTS and GEOS.
Review Comment:
Agreed, GEOS's clip_by_rect uses a fast clipping algorithm that treats the
boundary differently from a full intersection. It's arguably a quirk rather
than intentional behavior. Glad the documentation captures the difference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
