piyushka-ally commented on code in PR #2784:
URL: https://github.com/apache/sedona/pull/2784#discussion_r3019780059
##########
python/sedona/spark/geopandas/base.py:
##########
@@ -3073,6 +3049,73 @@ def dwithin(self, other, distance, align=None):
"""
return _delegate_to_geometry_column("dwithin", self, other, distance,
align)
+ def clip_by_rect(self, xmin, ymin, xmax, ymax):
+ """Returns a ``GeoSeries`` of the portions of geometry within the
+ given rectangle.
+
+ The geometry is clipped to the rectangle defined by the given
+ coordinates. Geometries that do not intersect the rectangle are
+ returned as empty polygons (``POLYGON EMPTY``).
+
+ .. note::
+ This implementation uses ``ST_Intersection`` with a rectangle
+ envelope, which may produce slightly different results from
+ geopandas' ``clip_by_rect`` in edge cases:
+
+ - Non-intersecting geometries are returned as ``POLYGON EMPTY``,
+ whereas geopandas returns ``GEOMETRYCOLLECTION EMPTY``.
+ - Points on the boundary of the rectangle are considered
+ intersecting and are returned unchanged, whereas geopandas
+ returns ``GEOMETRYCOLLECTION EMPTY``.
Review Comment:
Applied, thanks for the suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
