PhillHenry commented on code in PR #3729:
URL: https://github.com/apache/polaris/pull/3729#discussion_r2897124396
##########
polaris-core/src/main/java/org/apache/polaris/core/connection/iceberg/IcebergRestConnectionConfigInfoDpo.java:
##########
@@ -43,19 +43,31 @@
public class IcebergRestConnectionConfigInfoDpo extends ConnectionConfigInfoDpo
implements IcebergCatalogPropertiesProvider {
+ private static final String QUOTA_PROJECT_ID_HEADER_KEY =
"x-goog-user-project";
Review Comment:
I named it this as that's what it's called in
`com.google.auth.oauth2.GoogleCredentials`.
But I've changed it now to something more generic.
##########
polaris-core/src/main/java/org/apache/polaris/core/connection/iceberg/IcebergRestConnectionConfigInfoDpo.java:
##########
@@ -43,19 +43,31 @@
public class IcebergRestConnectionConfigInfoDpo extends ConnectionConfigInfoDpo
implements IcebergCatalogPropertiesProvider {
+ private static final String QUOTA_PROJECT_ID_HEADER_KEY =
"x-goog-user-project";
+
private final String remoteCatalogName;
+ @Nullable
+ public Map<String, String> getAdditionalHeaders() {
+ return additionalHeaders;
+ }
+
+ @Nullable private final Map<String, String> additionalHeaders;
+
public IcebergRestConnectionConfigInfoDpo(
@JsonProperty(value = "uri", required = true) @Nonnull String uri,
@JsonProperty(value = "authenticationParameters", required = true)
@Nonnull
AuthenticationParametersDpo authenticationParameters,
@JsonProperty(value = "serviceIdentity", required = false) @Nullable
ServiceIdentityInfoDpo serviceIdentityInfo,
@JsonProperty(value = "remoteCatalogName", required = false) @Nullable
- String remoteCatalogName) {
+ String remoteCatalogName,
+ @JsonProperty(value = "additionalHeaders", required = false) @Nullable
Review Comment:
Added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
