MonkeyCanCode opened a new pull request, #171:
URL: https://github.com/apache/polaris-tools/pull/171
This PR cover couple of things:
1. Added missing license header for `console/Makefile`
2. Matched license header `benchmarks/Makefile` to other Makefiles we have
3. Removed begin/end echo statements from top level Makefile into inner
Makefile (so both ways are use-able)
4. Sorted Makefile files for easier read-ability
5. Add version target per project
6. Silent commands via `@` prefix within Makefile so command itself don't
get print on the screen in console project
Here is before (which only top level Makefile will show helper msg):
```
➜ polaris-tools git:(main) ✗ make
Usage:
make <target>
General
help Display this help
Benchmarks
benchmarks-create-dataset-simulation Run create dataset simulation
benchmarks-read-simulation Run read simulation
benchmarks-read-update-simulation Run read/update simulation
benchmarks-create-commits-simulation Run create commits simulation
benchmarks-weighted-workload-simulation Run weighted workload simulation
benchmarks-reports-list List benchmark reports
benchmarks-reports-clean Clean benchmark reports
Console
console-build Build console project
console-build-docker Build docker image for console
project
console-dev Run the console project in
development mode
console-format-check Check formatting in the console
project
console-format-fix Fix formatting in the console
project
console-install Install dependencies for console
project
console-lint Lint the console project
console-lint-fix Fix linting issues in the
console project
```
Here is the after when invoking with top level Makefile:
```
➜ polaris-tools git:(makefile_refactor) ✗ make
Usage:
make <target>
General
help Display this help
Benchmarks
benchmarks-create-commits-simulation Run create commits simulation
benchmarks-create-dataset-simulation Run create dataset simulation
benchmarks-read-simulation Run read simulation
benchmarks-read-update-simulation Run read/update simulation
benchmarks-reports-clean Clean benchmark reports
benchmarks-reports-list List benchmark reports
benchmarks-weighted-workload-simulation Run weighted workload simulation
benchmarks-version Display version for benchmarks
project
Console
console-build Build console project
console-build-docker Build docker image for console
project
console-dev Run the console project in
development mode
console-format-check Check formatting in the console
project
console-format-fix Fix formatting in the console
project
console-install Install dependencies for console
project
console-lint Lint the console project
console-lint-fix Fix linting issues in the
console project
console-version Display version for console
project
```
Here is the after when invoking with console Makefile:
```
➜ console git:(makefile_refactor) ✗ make
Usage:
make <target>
General
help Display this help
version Display version information
Polaris Console
build Lint the console project
build-docker Build docker image for console
project
dev Run the console project in
development mode
format-check Fix formatting in the console
project
format-fix Fix linting issues in the
console project
install Install dependencies for console
project
lint Lint the console project
lint-fix Check formatting in the console
project
```
Here is the after when invoking with benchmark Makefile:
```
➜ benchmarks git:(makefile_refactor) ✗ make
Usage:
make <target>
General
help Display this help
version Display version information
Polaris Benchmark
create-commits-simulation Run create commits simulation
create-dataset-simulation Run create dataset simulation
read-simulation Run read simulation
read-update-simulation Run read/update simulation
reports-clean Clean benchmark reports
reports-list List benchmark reports
weighted-workload-simulation Run weighted workload simulation
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
