MonkeyCanCode opened a new pull request, #3829: URL: https://github.com/apache/polaris/pull/3829
<!-- ๐ Describe what changes you're proposing, especially breaking or user-facing changes. ๐ See https://github.com/apache/polaris/blob/main/CONTRIBUTING.md for more. --> As we are a lot more new targets added in Makefile and more to be add in couple PRs, I think we should sort the target names within each section for easier read-ability. Here is before: ``` Usage: make <target> General help Display this help version Display version information Polaris Build build Build Polaris server, admin, and container images build-server Build Polaris server and container image build-admin Build Polaris admin and container image build-spark-plugin-3.5-2.12 Build Spark plugin v3.5 with Scala v2.12 build-spark-plugin-3.5-2.13 Build Spark plugin v3.5 with Scala v2.13 build-cleanup Clean build artifacts spotless-apply Apply code formatting using Spotless Gradle plugin. Polaris Client client-lint Run linting checks for Polaris client client-regenerate Regenerate the client code client-unit-test Run client unit tests client-integration-test Run client integration tests client-license-check Run license compliance check client-build Build client distribution. Pass FORMAT=sdist or FORMAT=wheel to build a specific format. client-nightly-publish Build and publish nightly version to Test PyPI client-cleanup Cleanup virtual environment and Python cache files Helm helm-install-plugins Install required Helm plugins (unittest, schema) helm-schema-verify Verify Helm chart JSON schema is up to date helm-schema-generate Generate Helm chart JSON schema from values.yaml helm-doc-generate Generate Helm chart documentation helm-doc-verify Verify Helm chart documentation is up to date helm-unittest Run Helm chart unittest helm-lint Run Helm chart lint check helm Run all Helm targets (schema, docs, unittest, lint) Minikube minikube-start-cluster Start the Minikube cluster minikube-stop-cluster Stop the Minikube cluster minikube-load-images Load local Docker images into the Minikube cluster minikube-cleanup Cleanup the Minikube cluster Pre-commit pre-commit Run tasks for pre-commit Dependencies check-dependencies Check if all requested dependencies are present install-dependencies-brew Install dependencies if not present via Brew install-optional-dependencies-brew Install optional dependencies if not present via Brew ``` Here is after: ``` Usage: make <target> General help Display this help version Display version information Polaris Build build Build Polaris server, admin, and container images build-admin Build Polaris admin and container image build-cleanup Clean build artifacts build-server Build Polaris server and container image build-spark-plugin-3.5-2.12 Build Spark plugin v3.5 with Scala v2.12 build-spark-plugin-3.5-2.13 Build Spark plugin v3.5 with Scala v2.13 spotless-apply Apply code formatting using Spotless Gradle plugin. Polaris Client client-build Build client distribution. Pass FORMAT=sdist or FORMAT=wheel to build a specific format. client-cleanup Cleanup virtual environment and Python cache files client-integration-test Run client integration tests client-license-check Run license compliance check client-lint Run linting checks for Polaris client client-nightly-publish Build and publish nightly version to Test PyPI client-regenerate Regenerate the client code client-unit-test Run client unit tests Helm helm Run all Helm targets (schema, docs, unittest, lint) helm-doc-generate Generate Helm chart documentation helm-doc-verify Verify Helm chart documentation is up to date helm-install-plugins Install required Helm plugins (unittest, schema) helm-lint Run Helm chart lint check helm-schema-generate Generate Helm chart JSON schema from values.yaml helm-schema-verify Verify Helm chart JSON schema is up to date helm-unittest Run Helm chart unittest Minikube minikube-cleanup Cleanup the Minikube cluster minikube-load-images Load local Docker images into the Minikube cluster minikube-start-cluster Start the Minikube cluster minikube-stop-cluster Stop the Minikube cluster Pre-commit pre-commit Run tasks for pre-commit Dependencies check-dependencies Check if all requested dependencies are present install-dependencies-brew Install dependencies if not present via Brew install-optional-dependencies-brew Install optional dependencies if not present via Brew ``` In case if we want to take up this one but wait for other PRs to be merged first (e.g. https://github.com/apache/polaris/pull/3812 and https://github.com/apache/polaris/pull/3802), I can come back later for this. ## Checklist - [x] ๐ก๏ธ Don't disclose security issues! (contact [email protected]) - [x] ๐ Clearly explained why the changes are needed, or linked related issues: Fixes # - [x] ๐งช Added/updated tests with good coverage, or manually tested (and explained how) - [x] ๐ก Added comments for complex logic - [x] ๐งพ Updated `CHANGELOG.md` (if needed) - [x] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
