MonkeyCanCode commented on code in PR #171: URL: https://github.com/apache/polaris-tools/pull/171#discussion_r2831392776
########## benchmarks/Makefile: ########## @@ -1,49 +1,87 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at # -# Licensed to the Apache Software Foundation (ASF) under one -# or more contributor license agreements. See the NOTICE file -# distributed with this work for additional information -# regarding copyright ownership. The ASF licenses this file -# to you under the Apache License, Version 2.0 (the -# "License"); you may not use this file except in compliance -# with the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, -# software distributed under the License is distributed on an -# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -# KIND, either express or implied. See the License for the -# specific language governing permissions and limitations -# under the License. +# http://www.apache.org/licenses/LICENSE-2.0 # +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Configures the shell for recipes to use bash, enabling bash commands and ensuring +# that recipes exit on any command failure (including within pipes). +SHELL = /usr/bin/env bash -o pipefail +.SHELLFLAGS = -ec + +## Variables +APPLICATION_CONF_PATH ?= application.conf Review Comment: Yes. So the current behavior is to to absolute path of `./application.conf` under dir `benchmarks/` while this file doesn't existed and user will need to create it from template. Now to keep this default behavior, above change will also default to absolute path of `application.conf` under dir `benchmarks/` but it will also allow users to set to a diff path such as following: ``` ➜ polaris-tools git:(makefile_refactor) ✗ APPLICATION_CONF_PATH=~/Desktop/application.conf make benchmarks-create-commits-simulation ``` This also means if users want to use relative path, then they do so via following: ``` ➜ polaris-tools git:(makefile_refactor) ✗ APPLICATION_CONF_PATH=src/gatling/resources/benchmark-defaults.conf make benchmarks-create-commits-simulation ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
