snazy commented on code in PR #3788:
URL: https://github.com/apache/polaris/pull/3788#discussion_r2822955993
##########
runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/AbstractIcebergCatalogTest.java:
##########
@@ -289,36 +275,9 @@ public void before(TestInfo testInfo) {
testInfo.getTestMethod().map(Method::getName).orElse("test"),
System.nanoTime());
bootstrapRealm(realmName);
- RealmContext realmContext = () -> realmName;
- QuarkusMock.installMockForType(realmContext, RealmContext.class);
+ realmContextHolder.set(() -> realmName);
polarisContext = callContext.getPolarisCallContext();
- EntityCache entityCache = createEntityCache(diagServices, realmConfig,
metaStoreManager);
Review Comment:
The option to run with no entity-cache was introduced for NoSQL.
> other custom impl. may elect
It's rather hypothetical. Any custom implementation would require its own
tests anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
