dimas-b commented on code in PR #3788:
URL: https://github.com/apache/polaris/pull/3788#discussion_r2822837895
##########
runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/AbstractIcebergCatalogTest.java:
##########
@@ -289,36 +275,9 @@ public void before(TestInfo testInfo) {
testInfo.getTestMethod().map(Method::getName).orElse("test"),
System.nanoTime());
bootstrapRealm(realmName);
- RealmContext realmContext = () -> realmName;
- QuarkusMock.installMockForType(realmContext, RealmContext.class);
+ realmContextHolder.set(() -> realmName);
polarisContext = callContext.getPolarisCallContext();
- EntityCache entityCache = createEntityCache(diagServices, realmConfig,
metaStoreManager);
Review Comment:
It is doable in code, though... NoSQL Persistence runs without an
`EntityCache`, so other customer impl. may elect to run without it too. My
point is that it's probably worth testing it in the general case, not only via
NoSQL Persistence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
