dimas-b commented on code in PR #3788:
URL: https://github.com/apache/polaris/pull/3788#discussion_r2818130181
##########
runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/AbstractIcebergCatalogTest.java:
##########
@@ -289,36 +275,9 @@ public void before(TestInfo testInfo) {
testInfo.getTestMethod().map(Method::getName).orElse("test"),
System.nanoTime());
bootstrapRealm(realmName);
- RealmContext realmContext = () -> realmName;
- QuarkusMock.installMockForType(realmContext, RealmContext.class);
+ realmContextHolder.set(() -> realmName);
polarisContext = callContext.getPolarisCallContext();
- EntityCache entityCache = createEntityCache(diagServices, realmConfig,
metaStoreManager);
Review Comment:
I believe testing without the `EntityCache` is still relevant since the
impl. of `EntityCache` may not always be present (the system can be set up
without it). Therefore, I think it makes sense to validate that Polaris still
works without it.
NoSQL test probably cover that use case to some extent, but it is still
possible with JDBC. I suppose it is not unrealistic to run JDBC Persistence
without `EntityCache` with (hypothetically) some other Persistence-level cache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
