dimas-b commented on code in PR #3694:
URL: https://github.com/apache/polaris/pull/3694#discussion_r2784230968
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -164,7 +165,8 @@ public static void enforceFeatureEnabledOrThrow(
.defaultValue(false)
.buildFeatureConfiguration();
- @SuppressWarnings("deprecation")
+ @SuppressWarnings(
+ "deprecation") // catalogConfigUnsafe() is deprecated, not the feature
config itself
Review Comment:
Sorry, my statement was not accurate. Doc changes in this PR LGTM, but I
suppose code comment change are not necessary.... but I guess the whole
`@SuppressWarnings` will be removed when `catalogConfigUnsafe()` is
un-deprecated, but I'm fine merging "as is".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
