flyrain commented on code in PR #3694:
URL: https://github.com/apache/polaris/pull/3694#discussion_r2783836131
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -164,7 +165,8 @@ public static void enforceFeatureEnabledOrThrow(
.defaultValue(false)
.buildFeatureConfiguration();
- @SuppressWarnings("deprecation")
+ @SuppressWarnings(
+ "deprecation") // catalogConfigUnsafe() is deprecated, not the feature
config itself
Review Comment:
I agreed with both of you. +1 on un-deprecating and rename to
deprecatedCatalogConfig. This PR focuses on the doc change. We can un-deprecate
the method later, which may need another discussion on dev ML. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
