dimas-b commented on code in PR #3694:
URL: https://github.com/apache/polaris/pull/3694#discussion_r2783420485
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -164,7 +165,8 @@ public static void enforceFeatureEnabledOrThrow(
.defaultValue(false)
.buildFeatureConfiguration();
- @SuppressWarnings("deprecation")
+ @SuppressWarnings(
+ "deprecation") // catalogConfigUnsafe() is deprecated, not the feature
config itself
Review Comment:
optional: even better, I'd prefer un-deprecating `catalogConfigUnsafe()`
because:
1) it is actually used as a first-class method in polaris-core to ensure
backward compatibility at the use level
2) downstream projects are not likely to abuse the `catalogConfigUnsafe()`
method due to the "unsafe" mark in the method name
3) the method may be useful downstream for the same reason it is used in
`polaris-core`
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -128,7 +128,8 @@ public static void enforceFeatureEnabledOrThrow(
.defaultValue(true)
.buildFeatureConfiguration();
- @SuppressWarnings("deprecation")
+ @SuppressWarnings(
+ "deprecation") // catalogConfigUnsafe() is deprecated, not the feature
config itself
Review Comment:
nit: maybe put the comment on a new line for nicer formatting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
