collado-mike commented on code in PR #2508:
URL: https://github.com/apache/polaris/pull/2508#discussion_r2326284072
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisMetaStoreManager.java:
##########
@@ -346,6 +348,21 @@ EntityResult loadEntity(
long entityId,
@Nonnull PolarisEntityType entityType);
+ /**
+ * Load a batch of entities given their {@link EntityNameLookupRecord}. Will
return an empty list
+ * if the input list is empty. Order in that returned list is the same as
the input list. Some
+ * elements might be NULL if the entity has been dropped.
+ *
+ * @param callCtx call context
+ * @param entityLookupRecords the list of entity lookup records to load
+ * @return a non-null list of entities corresponding to the lookup keys.
Some elements might be
+ * NULL if the entity has been dropped.
+ */
+ @Nonnull
+ EntitiesResult loadEntities(
Review Comment:
I like this option - happy to move forward with this approach. If we mirror
the cache APIs, do you think `EntityNameLookupRecord` still makes sense as an
input type? E.g., `loadEntitiesChangeTracking` takes `PolarisEntityId` as an
input type. We could introduce a similar type to allow batch load by name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
