collado-mike opened a new pull request, #2508: URL: https://github.com/apache/polaris/pull/2508
https://github.com/apache/polaris/pull/2290 introduced a new `loadEntities` variant, which is really a `listEntities` call that returns the complete `PolarisBaseEntity` rather than the `EntityNameLookupRecord`. A batch `loadEntities` call that functions similar to the `loadEntity`, when given an id, returns the identified entity, is also useful, notably for cases when you don't want to list all entities of a particular type (e.g., loading a set of Principal Roles or refreshing specific entities for the `EntityCache`). This introduces a new `loadEntities` API and renames the previous `loadEntities` to `listFullEntities`. The former now mirrors the `loadEntity` call by requiring a list of explicit `EntityNameLookupRecord`s. I used `EntityNameLookupRecord` because that is the return type for the original `listEntities` API, but also because `PolarisEntityCore` requires a `grantVersion`, which may not be present, e.g., if the caller only has the results of a `listEntities` call. I also wanted to mirror the existing `loadEntity` API, which requires an `PolarisEntityType` argument and the `PolarisEntityId` doesn't contain a type field. <!-- Possible security vulnerabilities: STOP here and contact [email protected] instead! Please update the title of the PR with a meaningful message - do not leave it "empty" or "generated" Please update this summary field: The summary should cover these topics, if applicable: * the motivation for the change * a description of the status quo, for example the current behavior * the desired behavior * etc PR checklist: - Do a self-review of your code before opening a pull request - Make sure that there's good test coverage for the changes included in this PR - Run tests locally before pushing a PR (./gradlew check) - Code should have comments where applicable. Particularly hard-to-understand areas deserve good in-line documentation. - Include changes and enhancements to the documentation (in site/content/in-dev/unreleased) - For Work In Progress Pull Requests, please use the Draft PR feature. Make sure to add the information BELOW this comment. Everything in this comment will NOT be added to the PR description. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
