dimas-b commented on code in PR #2508:
URL: https://github.com/apache/polaris/pull/2508#discussion_r2326211890
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisBaseEntity.java:
##########
@@ -339,10 +339,7 @@ public boolean equals(Object o) {
PolarisBaseEntity that = (PolarisBaseEntity) o;
return subTypeCode == that.subTypeCode
&& createTimestamp == that.createTimestamp
- && dropTimestamp == that.dropTimestamp
- && purgeTimestamp == that.purgeTimestamp
Review Comment:
I do not have a strong objection, but the old equals code appears to treat
these objects as "value" objects, meaning and difference in any attribute would
lead to objects being different. That's just my observation on the code local
to this class.
That said, I do not really think these objects are used as value objects by
Polaris code other than the related tests, so the change is probably ok.
On the other hand, do tests have to compare objects in "whole"? Could ID
comparison be sufficient?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
