eric-maynard commented on code in PR #2007:
URL: https://github.com/apache/polaris/pull/2007#discussion_r2196452642
##########
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java:
##########
@@ -124,6 +124,18 @@ T cast(Object value) {
return this.typ.cast(value);
}
+ public String key() {
+ return key;
+ }
+
+ public String description() {
+ return description;
+ }
+
+ public T defaultValue() {
+ return defaultValue;
+ }
Review Comment:
Yeah I was thinking the same in my original comment, if the accessors are
`public final` then we at least do not have to worry about divergence in the
immediate concern and then the only real issue is that we're changing the API
for seemingly no value.
> Break points on a field do not work well in my experience (e.g. they do
not catch reflected access, IIRC).
Watches are generally used for fields, not breakpoints. Reflection and
proxying can cause issues for both fields and methods, which is one reason to
avoid them. Unfortunately, you can observe this when working with breakpoints
in many proxied objects in Polaris today. Watches on values do not have this
problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
