dimas-b commented on code in PR #2007:
URL: https://github.com/apache/polaris/pull/2007#discussion_r2195883220
##########
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java:
##########
@@ -124,6 +124,18 @@ T cast(Object value) {
return this.typ.cast(value);
}
+ public String key() {
+ return key;
+ }
+
+ public String description() {
+ return description;
+ }
+
+ public T defaultValue() {
+ return defaultValue;
+ }
Review Comment:
> With private fields like this, there's a chance that
BehaviorChangeConfiguration and FeatureConfiguration can diverge from one
another and from PolarisConfiguration in unexpected ways. If nothing else the
fields should be protected.
I'm fine with `protected` fields if they are also `final`.
In this case, I do not think it is necessary. If we're concerned with
preserving the behaviour of field accessors, we could make the accessor methods
`public` and `final`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
