snazy commented on code in PR #2007:
URL: https://github.com/apache/polaris/pull/2007#discussion_r2194570294
##########
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java:
##########
@@ -124,6 +124,18 @@ T cast(Object value) {
return this.typ.cast(value);
}
+ public String key() {
+ return key;
+ }
+
+ public String description() {
+ return description;
+ }
+
+ public T defaultValue() {
+ return defaultValue;
+ }
Review Comment:
`public` fields are generally considered bad practice, carefully designed
interfaces are generally preferred. This is how things are composable and
provide much better backwards compatibility. There are a lot of prominent
examples in Java's core libraries. (Spoiler: Would anyone expect
`java.util.Map.Entry.key` being a field?)
In the past, a lot of changes went into Polaris that count as "breaking
changes" according to the above arguments. Some received strong objections
while others were just approved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
