adutra commented on code in PR #2001: URL: https://github.com/apache/polaris/pull/2001#discussion_r2192532625
########## helm/polaris/README.md.gotmpl: ########## @@ -96,15 +81,14 @@ The below instructions assume a local Kubernetes cluster is running and Helm is #### Common setup Create the target namespace: - ```bash kubectl create namespace polaris ``` Create all the required resources in the `polaris` namespace. This usually includes a Postgres -database and a Kubernetes Secret for the `persistence.xml` file. The Polaris chart does not create +database and a Kubernetes Secret for Polaris service certification files. The Polaris chart does not create Review Comment: ```suggestion database, Kubernetes secrets, and service accounts. The Polaris chart does not create ``` ########## helm/polaris/README.md.gotmpl: ########## @@ -96,15 +81,14 @@ The below instructions assume a local Kubernetes cluster is running and Helm is #### Common setup Create the target namespace: - ```bash kubectl create namespace polaris ``` Create all the required resources in the `polaris` namespace. This usually includes a Postgres -database and a Kubernetes Secret for the `persistence.xml` file. The Polaris chart does not create +database and a Kubernetes Secret for Polaris service certification files. The Polaris chart does not create these resources automatically, as they are not required for all Polaris deployments. The chart will -fail if these resources are not created beforehand. +fail if these resources are not created beforehand. You can find a reference for these resources in the `Prerequisites` section within `Development & Testing`. Review Comment: ```suggestion fail if these resources are not created beforehand. You can find some examples in the `helm/polaris/ci/fixtures` directory, but beware that these are primarily intended for tests. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
