adutra commented on code in PR #2001:
URL: https://github.com/apache/polaris/pull/2001#discussion_r2190772648
##########
helm/polaris/README.md.gotmpl:
##########
@@ -89,22 +71,7 @@ eval $(minikube -p minikube docker-env)
-Dquarkus.container-image.build=true
```
-### Installing the chart locally
-
-The below instructions assume a local Kubernetes cluster is running and Helm
is installed.
-
-#### Common setup
-
-Create the target namespace:
-
-```bash
-kubectl create namespace polaris
-```
-
-Create all the required resources in the `polaris` namespace. This usually
includes a Postgres
Review Comment:
OK but this paragraph is imho important because it tells users that they
_must_ install the prerequisites now before proceeding, otherwise, the Helm
chart installation may fail.
That's also why I think that `--create-namespace` is generally useful only
in small deployments. As soon as lots of dependencies must be installed
(service accounts, secrets, the database, etc), it becomes impractical to
create the namespace during the Helm chart installation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
