adutra commented on code in PR #2001: URL: https://github.com/apache/polaris/pull/2001#discussion_r2190760143
########## helm/polaris/README.md.gotmpl: ########## @@ -113,67 +80,59 @@ Below are two sample deployment models for installing the chart: one with a non- > **These files are intended for testing purposes primarily, and may not be > suitable for production use**. > For production deployments, create your own values files based on the > provided examples. -#### Non-persistent backend +##### Non-persistent backend Install the chart with a non-persistent backend. From Polaris repo root: - ```bash helm upgrade --install --namespace polaris \ - --debug --values helm/polaris/ci/simple-values.yaml \ - polaris helm/polaris + --values helm/polaris/ci/simple-values.yaml \ + polaris helm/polaris --create-namespace polaris ``` Note: if you are running the tests on a Kind cluster started with the `run.sh` command explained above, then you need to run `helm upgrade` as follows: - ```bash helm upgrade --install --namespace polaris \ - --debug --values helm/polaris/ci/simple-values.yaml \ + --values helm/polaris/ci/simple-values.yaml \ --set=image.repository=localhost:5001/apache/polaris \ - polaris helm/polaris + polaris helm/polaris --create-namespace polaris ``` #### Persistent backend > [!WARNING] > The Postgres deployment set up in the fixtures directory is intended for > testing purposes only and is not suitable for production use. For production > deployments, use a managed Postgres service or a properly configured and > secured Postgres instance. -Install the chart with a persistent backend. From Polaris repo root: +Install the dependencies in fixtures directory. From Polaris repo root: Review Comment: Well, all the files in `ci/fixtures/` are completely useless for a production deployment. I'd prefer to just tell users to install whatever resources they need (secrets, service accounts, database, etc.) before installing the Helm chart. But telling them to install `ci/fixtures/` is imho a nonsense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
