eric-maynard commented on code in PR #1672:
URL: https://github.com/apache/polaris/pull/1672#discussion_r2108135918
##########
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java:
##########
@@ -162,13 +162,8 @@ public Builder<T> catalogConfig(String catalogConfig) {
return this;
}
- /**
- * Used to support backwards compatability before there were reserved
properties. Usage of this
- * method should be removed over time.
- */
- @Deprecated
Review Comment:
Only to users building from source. Otherwise, it's meant to be visible to
developers -- a reminder & incentive to deprecate the method, not one to just
yank the `@Deprecated` annotation.
If we're concerned about the verbosity of `./gradlew build`, these warnings
are a very small fraction of the output I see when building. There is lots of
other output which is much lower-signal to users, such as all the split package
warnings or the `Hibernate Validator` output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
