eric-maynard commented on code in PR #1672:
URL: https://github.com/apache/polaris/pull/1672#discussion_r2109613223
##########
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java:
##########
@@ -162,13 +162,8 @@ public Builder<T> catalogConfig(String catalogConfig) {
return this;
}
- /**
- * Used to support backwards compatability before there were reserved
properties. Usage of this
- * method should be removed over time.
- */
- @Deprecated
Review Comment:
Looks good! Just want to flag that there is a surviving log
[here](https://github.com/apache/polaris/blob/0a484bb32c867178cb2ddac24d1280bab8b34ab6/polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfigurationStore.java#L132),
but IMO we should keep that one because it tells users to stop using the
config, rather than developers to stop building Polaris with a method call in
place they can't actually remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
