eric-maynard commented on code in PR #1672:
URL: https://github.com/apache/polaris/pull/1672#discussion_r2107736690
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -131,7 +131,7 @@ public static void enforceFeatureEnabledOrThrow(
PolarisConfiguration.<Boolean>builder()
.key("ALLOW_EXTERNAL_TABLE_LOCATION")
.catalogConfig("polaris.config.allow.external.table.location")
- .catalogConfigUnsafe("allow.external.table.location")
+ .legacyCatalogConfig("allow.external.table.location")
Review Comment:
I still like `unsafe` because it suggests the unsafe nature of the method --
it's not clear to me what "legacy" means here. It's old, but, what's different
about it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
