dimas-b commented on code in PR #1624:
URL: https://github.com/apache/polaris/pull/1624#discussion_r2098868358
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -232,7 +222,16 @@ public String name() {
}
@VisibleForTesting
- public FileIO getIo() {
+ public synchronized FileIO getIo() {
+ if (catalogFileIO == null) {
+ LOGGER.debug(
+ "Initializing a default catalogFileIO with properties {}",
tableDefaultProperties);
+ catalogFileIO = loadFileIO(ioImplClassName, tableDefaultProperties);
Review Comment:
Yes, looking at the test code, `IcebergCatalog` objects are created by tests
for tests, so I believe since we started this cleanup effort, it makes sense
for these tests to own FileIO creation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
