dimas-b commented on code in PR #1624:
URL: https://github.com/apache/polaris/pull/1624#discussion_r2097962836
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -232,7 +222,16 @@ public String name() {
}
@VisibleForTesting
- public FileIO getIo() {
+ public synchronized FileIO getIo() {
+ if (catalogFileIO == null) {
+ LOGGER.debug(
+ "Initializing a default catalogFileIO with properties {}",
tableDefaultProperties);
+ catalogFileIO = loadFileIO(ioImplClassName, tableDefaultProperties);
Review Comment:
This used to be performed only when
`INITIALIZE_DEFAULT_CATALOG_FILEIO_FOR_TEST` was `true`. Now it appears to be
performed in all cases... do I read it correctly? If so, what's the rationale
for this behaviour change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
