flyrain commented on code in PR #1624:
URL: https://github.com/apache/polaris/pull/1624#discussion_r2098865660
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -232,7 +222,16 @@ public String name() {
}
@VisibleForTesting
- public FileIO getIo() {
+ public synchronized FileIO getIo() {
+ if (catalogFileIO == null) {
+ LOGGER.debug(
+ "Initializing a default catalogFileIO with properties {}",
tableDefaultProperties);
+ catalogFileIO = loadFileIO(ioImplClassName, tableDefaultProperties);
Review Comment:
What do you mean by "inject"? A setter will face exactly the same issue,
which is public and only used by tests.
Or are you talking about a subclass?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
