HonahX commented on code in PR #1529:
URL: https://github.com/apache/polaris/pull/1529#discussion_r2096578731
##########
spec/polaris-management-service.yml:
##########
@@ -1387,6 +1417,26 @@ components:
- tableName
- privilege
+ PolicyGrant:
+ allOf:
+ - $ref: '#/components/schemas/GrantResource'
+ - type: object
+ properties:
+ namespace:
+ type: array
+ items:
+ type: string
+ policyName:
+ type: string
+ minLength: 1
+ maxLength: 256
Review Comment:
Yes, it's weird that we have these length limitations on tableNames,
namespaceName, etc. Let me remove that for policy in this PR, since even if we
need the limitation, we need that to appear in `policy-api.yaml` too. Let's
deal with other existing length limitations in a follow-up PR/dev discussion.
I do not think we necessarily need pattern restriction on policy name here
as management APIs does not create new policies, any invalid names would just
result in an not found error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
