HonahX commented on code in PR #1529:
URL: https://github.com/apache/polaris/pull/1529#discussion_r2096198389
##########
spec/polaris-management-service.yml:
##########
@@ -1278,6 +1278,20 @@ components:
- TABLE_READ_DATA
- TABLE_WRITE_DATA
- TABLE_FULL_METADATA
+ - TABLE_ATTACH_POLICY
+ - TABLE_DETACH_POLICY
+
+ PolicyPrivilege:
+ type: string
+ enum:
+ - CATALOG_MANAGE_ACCESS
+ - POLICY_READ
+ - POLICY_DROP
+ - POLICY_WRITE
+ - POLICY_LIST
+ - POLICY_FULL_METADATA
Review Comment:
Naming is not an easy task. For me both `_FULL_METADATA` and `_FULL_ACCESS`
makes sense, but since in polaris we use `_FULL_METADATA` frequently:
`CATALOG_FULL_METADATA`, `NAMESPACE_FULL_METADATA`, ... I think
`POLICY_FULL_METADATA` can be more consistent with Polaris' naming convention.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
