sfc-gh-yzou commented on code in PR #1529:
URL: https://github.com/apache/polaris/pull/1529#discussion_r2096555697
##########
spec/polaris-management-service.yml:
##########
@@ -1387,6 +1417,26 @@ components:
- tableName
- privilege
+ PolicyGrant:
+ allOf:
+ - $ref: '#/components/schemas/GrantResource'
+ - type: object
+ properties:
+ namespace:
+ type: array
+ items:
+ type: string
+ policyName:
+ type: string
+ minLength: 1
+ maxLength: 256
Review Comment:
I am actually not quite sure if i got this part, I double checked the
policyName definition, which is the following
```
type: string
pattern: '^[A-Za-z0-9\-_]+$'
```
there is no min and max limitation, will we run into the problem that when
we create the policy, the name might exceed the limitation, but when we grant
the the policy, user see the error. Should all those limitation be defined on
the policyName, and here we just refer to the policy name definition, similar
as privilege?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
