singhpk234 commented on code in PR #1496:
URL: https://github.com/apache/polaris/pull/1496#discussion_r2067469845
##########
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java:
##########
@@ -93,11 +93,7 @@ public void writeEntity(
boolean nameOrParentChanged,
PolarisBaseEntity originalEntity) {
try {
- datasourceOperations.runWithinTransaction(
- statement -> {
- persistEntity(callCtx, entity, originalEntity, statement);
- return true;
- });
+ persistEntity(callCtx, entity, originalEntity, datasourceOperations);
Review Comment:
I do agree on retries on conflict before giving up, and 5xx not being thrown
but i think we should not use transaction where not required, atleast in this
case we don't require transaction ? like even if the retries fixes the issue
and but we spent some time which will impact the p95 atleast as we would
ideally want to retry after sleep ?
I propose handling re-try in transaction and 5xx in a seperate pr, and
atleast have this pr (I have draft of latter already) go in as it eliminates
the need for transaction. thoughts ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
