singhpk234 commented on code in PR #1496:
URL: https://github.com/apache/polaris/pull/1496#discussion_r2067584368
##########
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java:
##########
@@ -93,11 +93,7 @@ public void writeEntity(
boolean nameOrParentChanged,
PolarisBaseEntity originalEntity) {
try {
- datasourceOperations.runWithinTransaction(
- statement -> {
- persistEntity(callCtx, entity, originalEntity, statement);
- return true;
- });
+ persistEntity(callCtx, entity, originalEntity, datasourceOperations);
Review Comment:
I see "transaction" in our API, as if why do we want to setAutoCommit false
and then execute and then doCommit rather than writing it with autoCommit to
true ? IMHO, we should not do this for a single statement which we know we want
to commit, we don't need isolation neither we wanna refer back to uncommitted
change atleast for this context this seems to me like an overkill, and the perf
number suggests the same.
I agree with the retries and not giving up from the persistence layer
without retrying. definitely we should fix that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
