singhpk234 opened a new pull request, #1496:
URL: https://github.com/apache/polaris/pull/1496
### About the change
Change attempts to remove the runInTransaction from atomic operations as
this is contributing to error of transaction having cyclic dependency and
throwing 5xx if we just move back to atomic select it would yeild in better
success rate
Note : I did try out passing a Consumer and sneakyThrow but it does
introduce another set of if-elses so settled on this for now. Open to other
suggestions.
#### withRunInTransaction
```
========================================================================================================================
---- Global Information
-------------------------------------------------------------|---Total---|-----OK----|----KO----
> request count
| 30,108 | 30,092 | 16
> min response time (ms)
| 1 | 1 | 7
> max response time (ms)
| 603 | 603 | 243
> mean response time (ms)
| 17 | 17 | 99
> response time std deviation (ms)
| 23 | 23 | 74
> response time 25th percentile (ms)
| 6 | 6 | 44
> response time 50th percentile (ms)
| 11 | 11 | 76
> response time 75th percentile (ms)
| 22 | 22 | 171
> response time 99th percentile (ms)
| 96 | 94 | 243
> mean throughput (rps)
| 83.4 | 83.36 | 0.04
---- Response Time Distribution
----------------------------------------------------------------------------------------
> OK: t < 800 ms
30,092 (99.95%)
> OK: 800 ms <= t < 1200 ms
0 (0%)
> OK: t >= 1200 ms
0 (0%)
> KO
16 (0.05%)
---- Errors
------------------------------------------------------------------------------------------------------------
> status.find.is(200), but actually found 500
15 (93.75%)
> status.find.is(204), but actually found 500
1 (6.25%)
========================================================================================================================
```
### without runInTransaction
```
========================================================================================================================
---- Global Information
-------------------------------------------------------------|---Total---|-----OK----|----KO----
> request count
| 30,009 | 30,001 | 8
> min response time (ms)
| 1 | 1 | 10
> max response time (ms)
| 293 | 293 | 89
> mean response time (ms)
| 16 | 16 | 33
> response time std deviation (ms)
| 16 | 16 | 27
> response time 25th percentile (ms)
| 6 | 6 | 16
> response time 50th percentile (ms)
| 12 | 12 | 20
> response time 75th percentile (ms)
| 23 | 23 | 60
> response time 99th percentile (ms)
| 77 | 76 | 89
> mean throughput (rps)
| 83.13 | 83.11 | 0.02
---- Response Time Distribution
----------------------------------------------------------------------------------------
> OK: t < 800 ms
30,001 (99.97%)
> OK: 800 ms <= t < 1200 ms
0 (0%)
> OK: t >= 1200 ms
0 (0%)
> KO
8 (0.03%)
---- Errors
------------------------------------------------------------------------------------------------------------
> status.find.is(200), but actually found 500
6 (75%)
> status.find.is(204), but actually found 500
2 (25%)
========================================================================================================================
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]